On Fri, Apr 5, 2013 at 6:57 PM, Jakub Narębski <jna...@gmail.com> wrote: >>> +void format_decoration(struct strbuf *sb, >>> + const struct commit *commit, >>> + int use_color); >> >> I think you can fit these on a single line, especially if you drop >> the unused variable names (they help when there are more than one >> parameter of the same type to document the order of the arguments, >> but that does not apply here). That would help people who run >> "grep" on the header files without using CTAGS/ETAGS. > > Well, I think "int use_color" should be left with variable name, > don't you think?
I don't care too much about this. If Junio does not respond, I'll leave the names in place (in one long line). -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html