Ramkumar Ramachandra <artag...@gmail.com> writes: > Junio C Hamano wrote: >> The risk of actually closing the door for future developers. That >> is a downside of this patch, if we were to apply it. > > Okay, no issues. Drop it. > > Consider documenting the fact that IS_STASH_LIKE is merely a > contextual synonym for IS_MERGE_COMMIT somewhere though.
Documenting what IS_STASH_LIKE means and what it is meant to be used for would add a lot of value, if it is not done already, but I doubt it adds much value to document that it _happens to be implemented_ as "is it a merge commit?" in the current version. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html