Jonathan Nieder <jrnie...@gmail.com> writes:
> Ramsay Jones wrote:
>> After this change, it should be possible to drop the
>> CYGWIN_V15_WIN32API setting without any negative effect.
>> [rj: %s/NATIVE_WINDOWS/GIT_NATIVE_WINDOWS/g ]
>> Signed-off-by: Jonathan Nieder <jrnie...@gmail.com>
>> Signed-off-by: Ramsay Jones <ram...@ramsay1.demon.co.uk>
> Yay! Thanks for finishing it.
> For what it's worth,
> Reviewed-by: Jonathan Nieder <jrnie...@gmail.com>
Wait. The proposed commit log message talks about native-windows
but throughout the code it is windows-native [I'll reword when I
rebase-i to add your reviewed-by].
While I really like seeing an unfinished topic completed by tying
its loose ends like this patch does, it feels a bit too late for the
cycle, especially given that we _know_ the changes still need to be
tested on a platform that the series is expected to affect.
Could somebody who builds regularly on Cygwin 1.7 try to see if
these two patches are OK?
Reports from people without previous experience with Git on Cygwin
who freshly install Cygwin 1.7 only to test these two patches do not
count, because they do not know what is expected and cannot tell
regressions from know limitations.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html