Am 5/2/2013 17:46, schrieb Jeff King:
> On Thu, May 02, 2013 at 09:05:01AM +0200, Johannes Sixt wrote:
>> BTW, do you notice that the function is now modifying an object (the hash
>> table) even though this is rather unexpected from a "lookup" function?
> I think this is fine. The function is conceptually constant from the
> outside; callers don't even know about the hash table. They just know
> that there is some mapping. It's similar to the way that lookup_commit
> will lazily allocate the "struct commit". The callers do not care
> whether it exists already or not; they care that at the end of the
> function, they have a pointer to the commit. Everything else is an
> implementation detail.

Can we be sure that the function is never invoked in concurrently from
different threads? I attempted to audit code paths, but quickly gave up
because I know too little about this machinery.

-- Hannes
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to