On Thu, May 09, 2013 at 06:20:18PM +0200, Heiko Voigt wrote:

> +static int config_buf_fgetc(struct config_source *conf)
> +{
> +     if (conf->buf.pos < conf->buf.len && conf->buf.buf[conf->buf.pos])
> +             return conf->buf.buf[conf->buf.pos++];
> +
> +     return EOF;
> +}

It probably would not matter for config reading, but is there any reason
not to make your fgetc replacement 8-bit clean (i.e., to check only len,
and not worry about NUL characters)?

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to