Jiang Xin <worldhello....@gmail.com> writes:

> 2013/5/13 Matthieu Moy <matthieu....@grenoble-inp.fr>:
>> Jiang Xin <worldhello....@gmail.com> writes:
>>>  * color.interactive.<slot>: Use customized color for interactive
>>>    git-clean output (like git add --interactive). <slot> may be
>>>    prompt, header, help or error.
>> This should go to the documentation (a short summary is welcome in the
>> commit messages in addition, but users won't read this...)
>>> +     if (!prefixcmp(var, "color.interactive.")) {
>>> +             int slot = parse_clean_color_slot(var, 18);
>> For readability and maintainability: please use
>> strlen("color.interactive."), not 18.
> Feel like conventional:
>     git grep -C2 prefixcmp builtin/apply.c builtin/archive.c
> builtin/branch.c builtin/checkout.c

I know there are already many instances of this in the code, but I don't
think it's a good idea to add even more.

Matthieu Moy
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to