2013/5/13 Matthieu Moy <matthieu....@grenoble-inp.fr>: >> + /* Confirmation dialog */ >> + printf(_("Remove ([y]es/[n]o/[e]dit) ? ")); > > To be more consistent with "git add -p", this should use  instead of > (), and have no space before "?".
Will be replaced with: printf(_("Remove [y/n]? ")); > >> + die(_("clean.requireForce defaults to true and neither >> -i, -n nor -f given; " >> "refusing to clean")); > > That makes it a 85 characters message, and we usually break lines before > 80. Adding \n after ";" (instead of a space) would be better IMO. > If die with multiple lines, it looks ugly. E.g. % git clean fatal: clean.requireForce defaults to true and neither -i, -n nor -f given; refusing to clean I think because of this, some die messages are longer than 80 characters. Such as: # builtin/apply.c:1496 die(Q_("git diff header lacks filename information when removing " "%d leading pathname component (line %d)", "git diff header lacks filename information when removing " "%d leading pathname components (line %d)", -- Jiang Xin http://www.worldhello.net/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html