Stefano Lattarini wrote:
On 05/26/2013 10:05 PM, Stefan Beller wrote:
Reported by cppcheck.

Signed-off-by: Stefan Beller <>
 fast-import.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fast-import.c b/fast-import.c
index 5f539d7..0142e3a 100644
--- a/fast-import.c
+++ b/fast-import.c
@@ -2914,7 +2914,7 @@ static void cat_blob(struct object_entry *oe,
 unsigned char sha1[20]) static void parse_cat_blob(void)
 const char *p;
- struct object_entry *oe = oe;

This was done on purpose, to avoid spurious warnings with (at least)
some versions of GCC.

+ struct object_entry *oe;
 unsigned char sha1[20];

 /* cat-blob SP <object> LF */

This strange construct has been removed in other places meanwhile. It is violating C-standards (C89, C99) and as such causes warnings with other compilers, so this is fighting fire with fire. As it is a pointer it may be more sensible to initialize with NULL, should appease all compilers and still be correct.

Bye, Jojo

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to