Felipe Contreras <felipe.contre...@gmail.com> writes: >> I don't see that, and I don't like adding a check that I don't expect to be >> ever needed. > > It's called self-documenting code; by adding a check for the NULL > pointer, we are stating that ce can be NULL, if we don't do that, > people reading that code would need to figure that out themselves.
People following the codepath to unpack_nondirectories() already have seen enough to know what src means and very well know what NULL in it means. The only people possibly confused are those who do not know free(NULL) is safe, isn't it? Honestly speaking, I do not want such people to be touching this part of the system. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html