On Sun, Jun 09, 2013 at 07:33:42PM +0200, SZEDER Gábor wrote:
> On Sun, Jun 09, 2013 at 12:23:01PM -0500, Felipe Contreras wrote:
> > On Sun, Jun 9, 2013 at 12:18 PM, SZEDER Gábor <sze...@ira.uka.de> wrote:
> > > On Sun, Jun 09, 2013 at 11:40:22AM -0500, Felipe Contreras wrote:
> > >> We should free objects before leaving.
> > >>
> > >> Signed-off-by: Felipe Contreras <felipe.contre...@gmail.com>
> > >
> > > A shortlog-friendlier subject could be: "sequencer: free objects
> > > before leaving".
> > I already defended my rationale for this succinct commit message:
> > http://thread.gmane.org/gmane.comp.version-control.git/225609/focus=225610
> Your arguments were unconvincing. The mere fact that I raised this
> issue unbeknownst to the earlier posting clearly shows that there's
> demand for descriptive subjects.
Not to mention that with your subject no body is needed, making the
overall message more succinct.
When reading a log, as soon as I see "trivial" I become suspicious that
someone is trying to cover something up, much like "left as an exercise
for the reader". If the subject says "fix memory leak" then it's
obvious what the patch is meant to do, and when there is no subtlety to
be explained (as there isn't in this patch) there is no need for a body.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html