On Sun, Jun 9, 2013 at 1:17 PM, Fredrik Gustafsson <[email protected]> wrote: > On Sun, Jun 09, 2013 at 11:40:21AM -0500, Felipe Contreras wrote: >> By using good ol' goto. >> >> Signed-off-by: Felipe Contreras <[email protected]> > > I don't see this as an indentation change but as a restructing of the > code. I would prefer something more like > "Replace early return with goto cleanup" (but better phrased).
The explains what the patch is doing, but not why. Why is more important. > The same goes for the next patch in this serie, I would prefer if the > shortlog tells what have been done, not how hard it was to do. It explains what it is, and why it makes sense. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
