Junio C Hamano <gits...@pobox.com> writes:

>> +{
>> +    if (files_list->nr) {
>> +            struct strbuf err_msg = STRBUF_INIT;
>> +            int i;
>> +            strbuf_addstr(&err_msg, main_msg);
>> +            for (i = 0; i < files_list->nr; i++)
>> +                    strbuf_addf(&err_msg,
>> +                                "\n    %s",
> Is there an implication of having always 4 spaces here to l10n/i18n
> here?  I am wondering if it should be _("\n    %s").

I'd say this is just formatting and should be the same in every
languages, but I'm far from an expert in the domain. Maybe some
right-to-left languages would need this.

>         test_expect_success 'rm files with different staged content' '
>                 cat >expect <<\-EOF &&

(that should be -\EOF, not \-EOF I think)

>  (2) by using a dash '-' before the end-of-here-text marker, you can
>      align the body of here text with a leading tab (HT).

This works because the list of files is aligned with spaces, but is
seems a bit fragile to me to use this -EOF on a text which uses
indentation. Anyway, I'm fine with both.

Matthieu Moy
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to