Richard Hartmann <richih.mailingl...@gmail.com> writes: > On Mon, Jun 10, 2013 at 9:52 PM, Junio C Hamano <gits...@pobox.com> wrote: > > >> I think offsetting the actual commands to the right is correct, but >> "if these match" and "if this is empty" should be flushed to left as >> this patch shows. > > I actually considered this and decided against it as it seemed to be > deliberate. Should I re-roll and re-send? > > I will gladly re-send the whole, or part of the, series once I know > which patches are OK and which need more work.
[PATCH 1/6] templates: Fewer subprocesses in pre-commit hook I agree with Peff that "less fork" is a bad justification for this change, and also echo 'First line second line third lie' looks somewhat bad. [PATCH 2/6] templates: Reformat pre-commit hook's message I think it is a good thing to make the output short by widening. [PATCH 3/6] templates: Fix spelling in pre-commit hook Good. [PATCH 4/6] Documentation: Update manpage for pre-commit hook I debated myself if it should say "The hook _by default_ prevents addition of non-ASCII filenames", hinting that it can be configured out if it is unwanted. Other than that, I think it is a good addition. [PATCH 5/6] templates: Fix ASCII art in pre-rebase hook Good, but see Peff's comments on the explanation. [PATCH 6/6] template: Fix comment indentation in pre-rebase hook After reading the original once again, it is fine as-is without the change at all, I think. Alternatively, "if these match" and "if this is empty" lines can be flushed to the left, which also is readable. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html