On Tue, Jun 11, 2013 at 12:41 PM, Fredrik Gustafsson <iv...@iveqy.com> wrote:
> On Tue, Jun 11, 2013 at 12:26:42PM -0500, Felipe Contreras wrote:
>> On Tue, Jun 11, 2013 at 12:24 PM, Fredrik Gustafsson <iv...@iveqy.com> wrote:
>> > On Tue, Jun 11, 2013 at 12:09:32PM -0500, Felipe Contreras wrote:
>> >> It's not removed. It's simply moved.
>> >
>> > Sorry about that, I wasn't paying enough attention. But why are you
>> > moving it?
>> >
>> > All other arguments to git am is set in git-rebase.sh, why just set
>> > -q just before the invokation in git-rebase--am.sh?
>> Because the next patch checks if there's any arguments meant for 'git
>> am' to switch to am rebase mode. We shouldn't switch to that mode if
>> the only argument to 'git am' is going to be -q.
> Okay, that make sense. How about rephrase the commit message and add
> this explanation. It's really not a cleanup but a preparation for the
> next patch.
> If I was a maintainer and only got this patch I would reject it. Every
> patch in a patch serie should be justified to be applied as a single
> patch, yes?

Yes, but it doesn't matter, because the maintainer has made it clear
he is not going to even read this patch series.

Felipe Contreras
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to