Michael Haggerty <mhag...@alum.mit.edu> writes: > On 06/12/2013 10:02 PM, Junio C Hamano wrote: >> Coaching new contributors, like mentoring GSoC students, is often >> more time consuming than scratching the same itch yourself for any >> reviewer, but it is an investment, which hopefully yields dividend >> in the longer term. > > Thanks for these concrete examples / suggestions for reviewers. I > remember especially that during my first contacts with the Git community > I was very impressed by these very things in your code reviews and in > those of other reviewers. > > Are you proposing that your text should find its way into the > CommunityGuidelines in some form?
It actually was the other way around ;-). After reading your message, I tried to think aloud by listing what I try to do, and I was impressed that your three-line advice was a very concise and very well written summary of that. I agree that a guideline should be kept as concise and clear as possible. The main point of my message was that reviewing and coaching may be costly, but we have to do them as an investment. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html