Ramkumar Ramachandra <artag...@gmail.com> writes:
> rebase should never write "checkout: " messages to the reflog, since it
> is highly confusing to the end user, and breaks
> grab_nth_branch_checkout(), as demonstrated by failing tests
> in t/checkout-last.
"breaks" because "the branch flipping rebase internally does is not
'checkout' as far as the end user is concerned", which essentially
is the tautology with the first part "should never write".
I would say
The branch flipping rebase internally does is not 'checkout' as
far as the end user is concerned; rebase should never write
"checkout: " messages to the reflog. Instead it should say
"rebase: checkout master".
> Set a sensible GIT_REFLOG_ACTION: checkout does not
> respect GIT_REFLOG_ACTION yet, but this defect will be addressed in a
> future patch.
That is not a defect; it did not have to so far, until this patch.
I suspect doing 6/6 before this patch may make more sense.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html