The logic for pulling into an unborn branch was originally designed to
be used on a newly-initialized repository (d09e79c, git-pull: allow
pulling into an empty repository, 2006-11-16). It thus did not
initially deal with uncommitted changes in the unborn branch. The
case of an _unstaged_ untracked file was fixed by by 4b3ffe5 (pull: do
not clobber untracked files on initial pull, 2011-03-25). However, it
still clobbered existing staged files, both when the file exists in
the merged commit (it will be overwritten), and when it does not (it
will be lost!).
We fix this by doing a two-way merge, where the "current" side of the
merge is an empty tree, and the "target" side is HEAD (already updated
to FETCH_HEAD at this point). This amounts to claiming that all work
in the index was done vs. an empty tree, and thus all content of the
index is precious.
Reported-by: Stefan Schüßler <m...@stefanschuessler.de>
Signed-off-by: Thomas Rast <tr...@inf.ethz.ch>
Stefan Schüßler <m...@stefanschuessler.de> writes:
> I think there's a bug in git pull. Doing a git pull in a fresh
> repository without any commits removes files in the index.
Thanks for the bug report!
git-pull.sh | 9 ++++++++-
t/t5520-pull.sh | 24 ++++++++++++++++++++++++
2 files changed, 32 insertions(+), 1 deletion(-)
diff --git a/git-pull.sh b/git-pull.sh
index 638aabb..1f84383 100755
@@ -266,10 +266,17 @@ case "$merge_head" in
+# Pulling into unborn branch: a shorthand for branching off
+# FETCH_HEAD, for lazy typers.
if test -z "$orig_head"
git update-ref -m "initial pull" HEAD $merge_head "$curr_head" &&
- git read-tree -m -u HEAD || exit 1
+ # Two-way merge: we claim the index is based on an empty tree,
+ # and try to fast-forward to HEAD. This ensures we will not
+ # lose index/worktree changes that the user already made on
+ # the unborn branch.
+ git read-tree -m -u $empty_tree HEAD || exit 1
diff --git a/t/t5520-pull.sh b/t/t5520-pull.sh
index 6af6c63..927903c 100755
@@ -57,6 +57,30 @@ test_expect_success 'pulling into void does not overwrite
untracked files' '
+test_expect_success 'pulling into void does not overwrite staged files' '
+ git init cloned-staged-colliding &&
+ cd cloned-staged-colliding &&
+ echo "alternate content" >file &&
+ git add file &&
+ test_must_fail git pull .. master &&
+ echo "alternate content" >expect &&
+ test_cmp expect file
+test_expect_success 'pulling into void does not remove new staged files' '
+ git init cloned-staged-new &&
+ cd cloned-staged-new &&
+ echo "new tracked file" >newfile &&
+ git add newfile &&
+ git pull .. master &&
+ echo "new tracked file" >expect &&
+ test_cmp expect newfile
test_expect_success 'test . as a remote' '
git branch copy master &&
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html