Alexey Shumkin <[email protected]> writes:
> @@ -19,7 +23,8 @@ add_file () {
> echo "$name" >"$name" &&
> git add "$name" &&
> test_tick &&
> - git commit -m "Add $name" || exit
> + msg_added_iso88595=$(echo "Add $name ($added $name)" |
> iconv -f utf-8 -t iso88595) &&
> + git -c 'i18n.commitEncoding=iso88595' commit -m
> "$msg_added_iso88595"
Hmph. Do we know 8859-5 is available or do these need to be
protected with prereq?
Can these tests be done with 8859-1 i.e. something we already depend
on, by changing that $added message to latin-1, or is there something
very Russian specific breakage we want to test here?
If the former, please redo this entire patch (not just t4041) with
8859-1.
If there is some Russian specific breakage you cannot demonstrate
with 8859-1, then please explain it in the log message.
> diff --git a/t/t6006-rev-list-format.sh b/t/t6006-rev-list-format.sh
> index d32e65e..36e4cc0 100755
> --- a/t/t6006-rev-list-format.sh
> +++ b/t/t6006-rev-list-format.sh
> ...
> -# usage: test_format name format_string <expected_output
> +# usage: test_format [failure] name format_string <expected_output
> test_format () {
> + local must_fail=0
This breaks tests for non-bash users. "local" is not even in POSIX.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
