Jiang Xin <worldhello....@gmail.com> writes:

> After substitute path_relative() in quote.c with relative_path() from
> path.c, parameters (such as len and prefix_len) are obsolete in function
> quote_path_relative(). Remove unused parameters and change the order of
> parameters for quote_path_relative() function.
> Signed-off-by: Jiang Xin <worldhello....@gmail.com>
> Signed-off-by: Junio C Hamano <gits...@pobox.com>
> ---

OK.  I'll amend the log message a bit to say that we verified that
this conversion is safe.

> diff --git a/quote.c b/quote.c
> index 64ff3..ebb8 100644

You seem to be using unusually short abbrev length.

Please don't, at least in format-patch output.

"ebb8" may be unique within your repository, but may not be unique
in repositories of other people who attempt to apply your patches.

Offtopic.  Fixing this, without forcing you to use the default
abbrev length everywhere, _might_ require a bit of changes to the
configuration mechanism, or "git format-patch", or both.  I've also
seen in some other thread that --numstat was used in addition to the
usual --stat, which should not be added to format-patch output only
because the user configured it for other "diff/log" uses, which may
also need to be fixed in the same way.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to