Ramkumar Ramachandra <artag...@gmail.com> writes:

>>     def get(self, name, default=''):
>>         try:
>>             values = self._split(read_git_output(
>>                     ['config', '--get', '--null', '%s.%s' % (self.section, 
>> name)],
>>                     env=self.env, keepends=True,
>>                     ))
> Wait, what is the point of using --null and then splitting by hand
> using a poorly-defined static method?  Why not drop the --null and
> splitlines() as usual?

You may actually have spotted a bug or misuse of "--get" here.

With this sample configuration:

        $ cat >sample <<\EOF
                one = value
                one = another

                one = "value\nanother"

A script cannot differentiate between them without using '--null'.

        $ git config -f sample --get-all a.one
        $ git config -f sample --get-all b.one

But that matters only when you use "--get-all", not "--get".  If
this method wants to make sure that the user did not misuse a.one
as a multi-valued configuration variable, use of "--null --get-all"
followed by checking how many items the command gives you back would
be a way to do so.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to