On 2013-08-03 08.50, Torsten Bögershausen wrote:
> On 2013-08-01 22.51, Ramsay Jones wrote:
>> Junio C Hamano wrote:
>>> Ramsay Jones <ram...@ramsay1.demon.co.uk> writes:
>>>>> I am personally in favor of this simpler solution. Comments?
>>>> I had expected this to me marked for 'master'.
>>>> Has this simply been overlooked, or do you have reservations about
>>>> applying this patch?
>>> I am just being careful and do want to keep it cooking in 'next'
>>> during the feature freeze. The more users work with 'next' (not
>>> "work *on* 'next'"), the more confidence we would be with, and
>>> hopefully this can be one of the topis that graduate early after
>>> the 1.8.4 release.
>> Hmm, this patch is a bug-fix for a bug that (currently) will be
>> _introduced_ by v1.8.4.
>> Do you want me to try and find a different bug-fix for v1.8.4?
>> (Although that would most likely be more risky than simply taking
>> this patch! ;-) ).
>> Ramsay Jones
> I just managed to run v1.8.4-rc1 under cygwin 1.7, and it all passed.
> Good work, thanks.
> I realized that core.filemode is true by default, which
> by default switches of the stat()/lstat() code in cygwin.c
> Which bug fix are we missing for v1.8.4 ?
Oh, the problem is of course that users have existing repos
where core.filemode = false.
So I think we can and should remove compat/cygwin.[ch] without further
cooking, to be on the save side.
(Just to be sure: this is what we are talking about ?)
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html