On Mon, Aug 5, 2013 at 11:00 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Brian Gernhardt <br...@gernhardtsoftware.com> writes:
>> compat/apple-common-crypto.h uses die() in one of its macros, but was
>> included in git-compat-util.h before the definition of die.
>> Fix by simply moving the relevant block after the die/error/warning
>> declarations.
> Puzzled.  What needs fixing???
> Ahh, that one is not just making #define macros, but defining static
> inline functions.
> I wonder if they need to be static inlines to be duplicated at each
> call sites in the first place.  Wouldn't it be better to create a
> compat/something.c file to be linked with?

IMO it's not worth it right now because there's only a single call
site (imap-send).  The moment another call site is introduced then
compat/apple-common-crypto.c would be the natural home for it.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to