On Sun, Aug 25, 2013 at 6:51 PM, Jeff King <p...@peff.net> wrote:
> On Sun, Aug 25, 2013 at 03:37:24PM +0200, Antoine Pelisse wrote:
>> So we would stop passing mailmap string_list along down to map_user(),
>> and the mailmap file (or blob) would be read the first time it's
>> needed, and stored in a static global variable in mailmap.c. I think
>> I'm OK with that because I don't think it would make sense to have
>> multiple instances of a mailmap string_list in the same git-command
> Exactly. Sample (largely untested) patch is below if you want to use it
> as a starting point. There are probably a few additional cleanups on top
> (e.g., "git log" understands "--mailmap", which should probably be
> centralized to handle_revision_opt).
I'm not exactly sure how I would improve the patch you sent. I
remember Junio was not willing to move --use-mailmap option to
revision options and wanted to keep it just for "log" (though I don't
have a reference to that email).
I've tested the patch against the test-suite and have given a thorough
read to it, and I think it's fine.
Would you mind sending it as a proper patch ? I have nothing to add,
and I'm terrible at writing commit messages :-/
Or maybe someone else's opinion would be nice. I'm still not convinced
this is even necessary.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html