On Tue, Sep 3, 2013 at 2:32 PM, Junio C Hamano <gits...@pobox.com> wrote:
> Felipe Contreras <felipe.contre...@gmail.com> writes:

>>  test_expect_success 'refuse --edit-description on unborn branch for now' '
>> +     test_when_finished "git checkout -" &&
>
> I am not sure if this is a good change.  Depending on the outcome of
> the "git checkout" in the test (it may succeed and set @{-1} to the
> branch we were on when we entered the test, or it may fail and leave
> @{-1} to the branch before we were on when we entered the test),
> this will take us to a different place, no?

It is better than leaving Git in an unborn branch. Many tests could
not care which is the current branch, as long as HEAD does points to a
branch, and that is the default, the tests should be messing with the
default.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to