[PATCH v2 08/14] index-pack: make sure all objects are registered in v4's SHA-1 table

[Nguyễn Thái Ngọc Duy]

---
 builtin/index-pack.c | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/builtin/index-pack.c b/builtin/index-pack.c
index 83e6e79..efb969a 100644
--- a/builtin/index-pack.c
+++ b/builtin/index-pack.c
@@ -288,6 +288,19 @@ static inline void *fill_and_use(int bytes)
        return p;
 }
 
+static void check_against_sha1table(const unsigned char *sha1)
+{
+       const unsigned char *found;
+       if (!packv4)
+               return;
+
+       found = bsearch(sha1, sha1_table, nr_objects, 20,
+                       (int (*)(const void *, const void *))hashcmp);
+       if (!found)
+               die(_("object %s not found in SHA-1 table"),
+                   sha1_to_hex(sha1));
+}
+
 static NORETURN void bad_object(unsigned long offset, const char *format,
                       ...) __attribute__((format (printf, 2, 3)));
 
@@ -907,6 +920,7 @@ static void resolve_delta(struct object_entry *delta_obj,
                bad_object(delta_obj->idx.offset, _("failed to apply delta"));
        hash_sha1_file(result->data, result->size,
                       typename(delta_obj->real_type), delta_obj->idx.sha1);
+       check_against_sha1table(delta_obj->idx.sha1);
        sha1_object(result->data, NULL, result->size, delta_obj->real_type,
                    delta_obj->idx.sha1);
        counter_lock();
@@ -1103,8 +1117,12 @@ static void parse_pack_objects(unsigned char *sha1)
                        /* large blobs, check later */
                        obj->real_type = OBJ_BAD;
                        nr_delays++;
-               } else
-                       sha1_object(data, NULL, obj->size, obj->type, 
obj->idx.sha1);
+                       check_against_sha1table(obj->idx.sha1);
+               } else {
+                       check_against_sha1table(obj->idx.sha1);
+                       sha1_object(data, NULL, obj->size, obj->type,
+                                   obj->idx.sha1);
+               }
                free(data);
                display_progress(progress, i+1);
        }
-- 
1.8.2.83.gc99314b

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html