On Sat, 21 Sep 2013, Nguyễn Thái Ngọc Duy wrote: > > Signed-off-by: Nguyễn Thái Ngọc Duy <pclo...@gmail.com> > --- > t/t5300-pack-object.sh | 39 ++++++++++++++++++++++----------------- > 1 file changed, 22 insertions(+), 17 deletions(-) [...]
This, in combination with patch 10/17, is making the test suite to test either packv4 or non packv4, and never both. I think this is not a good approach. Instead we should have packv2 specific tests to enforce --pack-version=2 when using pack-objects and create a duplicate of those tests for --pack-version=4 when that makes sense. For tests that are mostly common, the test could be factored out into a function with a pack version argument. Then, most tests could be always run twice: once for packv2 and again for packv4. Not doing so makes it more risky to regress packv2 when testing improvements to packv4 support. Nicolas
