Jonathan Nieder <[email protected]> wrote:
> Nicolas Vigier wrote:
>
> > When parsing a commit object, git-svn wrongly think that a line
> > containing spaces means the end of headers and the start of the commit
> > message. In case of signed commit, the gpgsig entry contains a line with
> > one space, so "git svn dcommit" will include part of the signature in
> > the commit message.
> >
> > An example of such problem :
> > http://svnweb.mageia.org/treasurer?view=revision&revision=86
> >
> > This commit changes the regex to only match an empty line as separator
> > between the headers and the commit message.
> >
> > Signed-off-by: Nicolas Vigier <[email protected]>
>
> Good catch. For what it's worth,
> Reviewed-by: Jonathan Nieder <[email protected]>
Thanks both. I've signed-off, added Jonathan's reviewed-by and
queued this up in my master. Currently at:
The following changes since commit 128a96c98442524c7f2eeef4757b1e48445f24ce:
Update draft release notes to 1.8.5 for the fifth batch of topics (2013-09-20
12:42:02 -0700)
are available in the git repository at:
git://git.bogomips.org/git-svn.git master
for you to fetch changes up to 945b9c14ffd3e11c916ee2b2428a0b2be9645829:
git-svn.txt: elaborate on rev_map files (2013-10-10 06:56:12 +0000)
----------------------------------------------------------------
Keshav Kini (4):
git-svn.txt: fix AsciiDoc formatting error
git-svn.txt: reword description of gc command
git-svn.txt: replace .git with $GIT_DIR
git-svn.txt: elaborate on rev_map files
Nicolas Vigier (1):
git-svn: fix signed commit parsing
Documentation/git-svn.txt | 46 +++++++++++++++++++++++++++++++++-------------
git-svn.perl | 2 +-
2 files changed, 34 insertions(+), 14 deletions(-)
--
Eric Wong
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
