Jens Lehmann <> writes:

>  static struct lock_file lock_file;
> +#define SUBMODULE_WITH_GITDIR ((const char *)1)

I don't like very much hardcoded addresses like this. Are you 100% sure
address 1 will never be returned by xstrdup on any platform? The risk is
small if not negligible, but I'm unconfortable with this. Isn't there an
alternative (NULL, or empty string) that is guaranteed to never happen?

> +test_expect_success 'git mv moves a submodule with a .git directory and 
> .gitmodules' '

This doesn't seem to test the problem I was having (move a file, not a
submodule). Is this intentional?

In any case, this fixes my problem, thanks!

Matthieu Moy
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to