Nicolas Vigier wrote:

> "the option is optional" was confusing as it is not the option but its
> argument which is optional.
>
> Signed-off-by: Nicolas Vigier <bo...@mars-attacks.org>

Thanks.

[...]
> --- a/Documentation/git-rev-parse.txt
> +++ b/Documentation/git-rev-parse.txt
> @@ -259,9 +259,10 @@ Each line of options has this format:
[...]
> -     * Use `?` to mean that the option is optional (though its use is 
> discouraged).
> +     * Use `?` if the option takes an optional argument (though its use is
> +       discouraged).

This still seems confusing: the argument's use is discouraged?

Would something like the following make sense?

        * Use `?` if [...]. This is used for historical options
          that once took no argument and later gained an optional
          argument. Use of this feature for new options is
          discouraged.

Hope that helps,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to