On Tue, Oct 22, 2013 at 8:42 PM, Junio C Hamano <[email protected]> wrote: > Duy Nguyen <[email protected]> writes:
>> Life would have been simpler if fd[1] was _always_ closed by >> send_pack(), like in c20181e (start_command(), if .in/.out > 0, closes >> file descriptors, not the callers - 2008-02-21). > > Yeah, that was also my first reaction when I saw the above three > lines after reading the discussion that led to the diagnosis. If send_pack() always closes fd[1], then I believe "git send-pack --stateless-rpc --helper-status" would die in print_helper_status(), called after send_pack(), since fd[1] would be 1, to which print_helper_status() will try to write. (I don't know what either --stateless-rpc or --helper-status mean, other than what's obvious from the code, or if the combination of them makes any sense.) I don't really have any more time to spend on this issue, so if a more thorough fix is required, I'm afraid someone else will have to work on it. / Jens -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
