Duy Nguyen <pclo...@gmail.com> writes:

> On Thu, Oct 24, 2013 at 12:52 AM, Junio C Hamano <gits...@pobox.com> wrote:
>> Nguyễn Thái Ngọc Duy <pclo...@gmail.com> writes:
>>> The strcpy call in open_output_fd() implies that the output buffer
>>> must be at least 25 chars long.
>> Hmph, where does that 25 come from?
>> [snipped]
> Much better. Thanks.

So where does that 25 come from?

We strcpy ".merge_link_XXXXXX" or ".merge_file_XXXXXX" into path[]
and run mkstemp() on it, and these templates are 18 bytes long, so I
am puzzled.

Is 25 "just a small random number that is surely longer than these
templates--did not bother to count how long the templates are"?
That's fine by me; I am just trying to make sure I am not missing
anything that turns these templates into a longer filename.


To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to