[+cc spearce; sorry, I really should have cc'd the whole series to you
     in the first place]

On Fri, Oct 25, 2013 at 08:16:18AM +0700, Nguyen Thai Ngoc Duy wrote:

> > +       - A header appears at the beginning:
> > +
> > +               4-byte signature: {'B', 'I', 'T', 'M'}
> > +
> > +               2-byte version number (network byte order)
> > +                       The current implementation only supports version 1
> > +                       of the bitmap index (the same one as JGit).
> I suppose this means if I want to extend pack bitmaps to be used on
> shallow clones, I need to step version to 2 before adding the shallow
> points in .bitmap file as there's no chance of modifying v1 anymore,
> correct?

It depends on how you want to change it. And what Shawn says. :)

This is an attempt to document the JGit format. My feeling is that there
should be a version bump if an existing implementation would barf on it,
and I assume Shawn would agree.  But if you want to simply add extra
data that would be ignored by an existing implementation, it would be OK
to add the data and mark it with a flag:

> > +               2-byte flags (network byte order)
> > +
> > +                       The following flags are supported:
> [...]

That's how we added the name-hash cache in the final patch.

That being said, JGit is _not_ happy with that, and complains when any
flags besides OPT_FULL are used.  Whether that is because I am
misinterpreting the intent of the flags field, or because JGit is being
overly strict is up for debate.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to