On 26 Nov 2013, at 16:28, René Scharfe <l....@web.de> wrote:
> Am 26.11.2013 23:18, schrieb Junio C Hamano:
>> René Scharfe <l....@web.de> writes:
>>> Thanks for the patches! Please send only one per message (the second
>>> one as a reply to the first one, or both as replies to a cover letter),
>>> though -- that makes commenting on them much easier.
>>> Side note: Documentation/SubmittingPatches doesn't mention that (yet),
>> OK, how about doing this then?
>> Documentation/SubmittingPatches | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>> diff --git a/Documentation/SubmittingPatches
>> index 7055576..304b3c0 100644
>> --- a/Documentation/SubmittingPatches
>> +++ b/Documentation/SubmittingPatches
>> @@ -140,7 +140,12 @@ comment on the changes you are submitting. It is
>> important for
>> a developer to be able to "quote" your changes, using standard
>> e-mail tools, so that they may comment on specific portions of
>> your code. For this reason, all patches should be submitted
>> -"inline". If your log message (including your name on the
>> +"inline". A patch series that consists of N commits is sent as N
>> +separate e-mail messages, or a cover letter message (see below) with
>> +N separate e-mail messages, each being a response to the cover
>> +If your log message (including your name on the
>> Signed-off-by line) is not writable in ASCII, make sure that
>> you send off a message in the correct encoding.
> OK, but the repetition of "cover letter" and "e-mail messages"
> irritates me slightly for some reason. What about the following?
> -- >8 --
> Subject: [PATCH] SubmittingPatches: document how to handle multiple patches
> Signed-off-by: Rene Scharfe <l....@web.de>
> Documentation/SubmittingPatches | 11 +++++++++--
> 1 files changed, 9 insertions(+), 2 deletions(-)
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index 7055576..e6d46ed 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -139,8 +139,15 @@ People on the Git mailing list need to be able to read
> comment on the changes you are submitting. It is important for
> a developer to be able to "quote" your changes, using standard
> e-mail tools, so that they may comment on specific portions of
> -your code. For this reason, all patches should be submitted
> -"inline". If your log message (including your name on the
> +your code. For this reason, each patch should be submitted
> +"inline" in a separate message.
> +Multiple related patches should be grouped into their own e-mail
> +thread to help readers find all parts of the series. To that end,
> +send them as replies to either an additional "cover letter" message
> +(see below), the first patch, or the respective preceding patch.
> +If your log message (including your name on the
> Signed-off-by line) is not writable in ASCII, make sure that
> you send off a message in the correct encoding.
That seems clear to me.
At any rate I’m going to rework this based on the collective input and will
submit them again.
Please check my other replies as there are some discussion points!
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html