From: Jeff King <>
> On Sat, Nov 30, 2013 at 02:51:18PM +0100, Christian Couder wrote:
>> Here is a patch series to improve the way sha1_object_info_extended()
>> behaves when it is passed a replaced object.
> Overall looks OK to me.

Thanks for reviewing it.

> I checked the resulting behavior against the list I made earlier; looks
> like all of the _extended callsites are doing the right thing.
> I do think the checks you added in 277336a (replace: forbid replacing an
> object with one of a different type, 2013-09-06) need updating. I
> started on that, but I wonder if all of cmd_replace should simply turn
> off read_replace_refs. I'd think it would always want to be dealing with
> the true objects.

Yeah, I think you are right. I will have a look and probably turn off
read_replace_ref in cmd_replace() as you suggest.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to