Aleksey Vasenev <margtu-f...@ya.ru> wrote:
> ---

What Thomas said about commit messages.

Note: I hardly use git-svn or SVN anymore and don't pay attention
to SVN changes.

Some style nitpicks:

> @@ -1304,16 +1318,20 @@ sub cmd_create_ignore {
>               # which git won't track
>               mkpath([$path]) unless -d $path;
>               my $ignore = $path . '.gitignore';
> -             my $s = $props->{'svn:ignore'} or return;
> +             my $s = &get_svn_ignore($props, 'svn:ignore');
> +             my $s_global = &get_svn_ignore($props, 'svn:global-ignores');

&sub(...) convention isn't consistent with the rest of our Perl code.
Do this instead:

                my $s = get_svn_ignore($props, 'svn:ignore');
                my $s_global = get_svn_ignore($props, 'svn:global-ignores');

> +             $s or $s_global or return;

Precedence should be more explicit:
                ($s || $s_global) or return;

Likewise for cmd_show_ignore.  Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to