David Kastrup <d...@gnu.org> writes:

> Ok, I now wrote
>       for (p = buf;; num++, p++) {
>               p = memchr(p, '\n', end - p);
>               if (!p)
>                       break;
>       }

Looks still wrong (perhaps this is a taste issue).

        num++ is not "loop control", but the real action of this
        loop to count lines.  It is better left inside.

        p++ is "loop control", and belongs to the third part of

        Isn't the normal continuation condition "p < end"?

so something like

        for (p = buf; p < end; p++) {
                p = find the end of this line
                if (!p)

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to