On Tue, Feb 11, 2014 at 11:29 PM, Chris Packham <judge.pack...@gmail.com> wrote: > Hi, > > On 12/02/14 14:57, Stefan Zager wrote: >> From b4796d9d99c03b0b7cddd50808a41413e45f1129 Mon Sep 17 00:00:00 2001 >> From: Stefan Zager <sza...@chromium.org> >> Date: Mon, 10 Feb 2014 16:55:12 -0800 >> Subject: [PATCH] Make the global packed_git variable static to sha1_file.c. > > I'm not really qualified to comment on substance but there are some > basic style issues w.r.t. whitespace namely using 4 spaces for indent > and mixing tabs/spaces. This might seem pedantic for the first round of > a patch but it does put off reviewers. > > From Documentation/CodingGuidelines: > > - We use tabs to indent, and interpret tabs as taking up to > 8 spaces.
My bad, I will upload a fixed patch. In my defense: I edited the code in emacs and then ran "M-x tabify" over the entire file. But that had the unfortunate side effect of adding a bunch of whitespace-only changes to the diff, illuminating the fact that there is already mixed whitespace in the existing code. So I had to go back and selectively tabify my changes, and I clearly missed a bunch. If anyone has a recommendation for a less labor-intensive way to do this in emacs, I'd be very grateful. Thanks, Stefan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html