On Fri, Feb 28, 2014 at 6:00 PM, Kirill Smelkov <k...@mns.spb.ru> wrote:
> On Fri, Feb 28, 2014 at 02:50:04PM +0100, Erik Faye-Lund wrote:
>> On Fri, Feb 28, 2014 at 2:44 PM, Erik Faye-Lund <kusmab...@gmail.com> wrote:
>> > On Mon, Feb 24, 2014 at 5:21 PM, Kirill Smelkov <k...@mns.spb.ru> wrote:
>> >> diff --git a/Makefile b/Makefile
>> >> index dddaf4f..0334806 100644
>> >> --- a/Makefile
>> >> +++ b/Makefile
>> >> @@ -316,6 +321,7 @@ endif
>> >> ifeq ($(uname_S),Windows)
>> >> GIT_VERSION := $(GIT_VERSION).MSVC
>> >> pathsep = ;
>> >> + HAVE_ALLOCA_H = YesPlease
>> >> NO_PREAD = YesPlease
>> >> NEEDS_CRYPTO_WITH_SSL = YesPlease
>> >> NO_LIBGEN_H = YesPlease
>> > In MSVC, alloca is defined in in malloc.h, not alloca.h:
>> > http://msdn.microsoft.com/en-us/library/wb1s57t5.aspx
>> > In fact, it has no alloca.h at all. But we don't have malloca.h in
>> > mingw either, so creating a compat/win32/alloca.h that includes
>> > malloc.h is probably sufficient.
>> "But we don't have alloca.h in mingw either", sorry.
> Don't we have that for MSVC already in
> ifeq ($(uname_S),Windows)
> BASIC_CFLAGS = ... -Icompat/vcbuild/include ...
> in config.mak.uname ?
Ah, of course. Thanks for setting me straight!
> And as I've not touched MINGW part in config.mak.uname the patch stays
> valid as it is :) and we can incrementally update what platforms have
> working alloca with follow-up patches.
> In fact that would be maybe preferred, for maintainers to enable alloca
> with knowledge and testing, as one person can't have them all at hand.
Yeah, you're probably right.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html