Jeff King <p...@peff.net> writes: > On Fri, Feb 28, 2014 at 12:04:19PM +0900, Brian Gesiak wrote: > >> From: modocache <modoca...@gmail.com> > > Both your emailed patches have this, which is due to your author name > not matching your sending identity. You probably want to set user.name, > or if you already have (which it looks like you might have from your > Signed-off-by), use "git commit --amend --reset-author" to update the > author information. > >> The install_branch_config function reimplemented the skip_prefix >> function inline. Use skip_prefix function instead for brevity. >> >> Signed-off-by: Brian Gesiak <modoca...@gmail.com> >> Reported-by: Michael Haggerty <mhag...@alum.mit.edu> > > It's a minor thing, but usually these footer lines try to follow a > chronological order. So the report would come before the signoff (and a > further signoff from the maintainer would go after yours). > >> diff --git a/branch.c b/branch.c >> index 723a36b..e163f3c 100644 >> --- a/branch.c >> +++ b/branch.c >> [...] > > The patch itself looks OK to me. > > -Peff
Thanks. Queued and pushed out on 'pu' with fixups already. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
