Who would have expected so much slop in one little function? Here are the changes coming out of a long email thread.
I feel a little bit silly submitting six separate patches, but they really are independent. And two of the changes were suggested by other people, so splitting those out, at least, helps give credit where it is due. But feel free to squash the patches together if you think it is best. Changes since v2 (aside from the atomization): * Use strchrnul() to initialize slash (as suggested by Junio) * Don't initialize variable at declaration (as per Junio's preference). Thanks to Junio and David for this workout. Michael Haggerty (6): cache_tree_find(): remove redundant checks cache_tree_find(): initialize slash using strchrnul() cache_tree_find(): fix comment formatting cache_tree_find(): remove redundant check cache_tree_find(): remove early return cache_tree_find(): use path variable when passing over slashes cache-tree.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) -- 1.9.0 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
