Eric Sunshine <sunsh...@sunshineco.com> writes:
>> +test_expect_failure 'edit hunk "commit -p -m message"' '
>> + echo e | env GIT_EDITOR="sed s/+line3\$/+line2/ -i" git commit -p -m
>> commit2 file &&
>> + git diff HEAD^ HEAD >diff &&
>> + test_cmp expected diff
> If you ever add more tests, is it likely that they will be using the
> same 'expected' file used by this test? If not, perhaps it makes sense
> to move creation of 'expected' into the test itself.
All good points. Also, I think we try to use "expect" (not
"expected") vs "actual" (not "diff") in most of the tests.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html