On Fri, Mar 14, 2014 at 2:00 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Duy Nguyen <pclo...@gmail.com> writes:
>> On Sat, Mar 8, 2014 at 2:20 AM, Junio C Hamano <gits...@pobox.com> wrote:
>>> Looking at "git grep -B3 OPT_NONEG" output, it seems that NONEG is
>>> associated mostly with OPTION_CALLBACK and OPTION_SET_INT in the
>>> existing code.
>>> Perhaps OPT_SET_INT should default to not just OPT_NOARG but also
>> There are OPT_SET_INT() that should not have NONEG in current code. So
>> there are two sets of SET_INT anyway. Either we convert them all to a
>> new macro that takes an extra flag, or we add OPT_SET_INT_NONEG() that
>> covers one set and leave the other set alone.
> Are you forgetting the third alternative, of swapping the default,
> if the ones that do not want NONEG are in the minority, to reduce
> the number of spelled-out instances?

There are 12 SET_INT with NONEG and 81 without (though I suspect some
of them should have NONEG). So NONEG is not exactly the majority. And
swapping does not go well with git development style, some in-flight
topics may introduce new OPT_SET_INT() that uses the old behavior.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to