On Sat, Mar 15, 2014 at 3:41 PM, Justin Lebar <jle...@google.com> wrote: > I got annoyed by git's awkward use of "nor" in man pages and in git add -p, so > I went ahead and audited all uses of "nor" in the tree. One might be able to > argue that some of the uses I've changed are technically acceptable, but > that's > a pretty low bar to set for ourselves. I aimed to make everything both > correct > and idiomatic.
I guess I'm cc'd because I made a few of those or/nor mistakes. Being a non-native English speaker I'm not really qualified to review this. But I suggest that you merge "Fix misuses of "nor" outside comments" and "Tests: Fix muses of "nor"" into one. Otherwise you break the test suite at 5/6 (and 6/6 fixes it, but breaking the test suite at any commit is not very bisect-friendly). -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html