On Fri, Mar 14, 2014 at 12:54 PM, Junio C Hamano <gits...@pobox.com> wrote: > Eric Sunshine <sunsh...@sunshineco.com> writes: > >> On Thu, Mar 13, 2014 at 4:20 PM, Yao Zhao <zhaox...@umn.edu> wrote: >>> Subject: [PATCH] GSoC Change multiple if-else statements to be table-driven >> >> It's a good idea to let reviewers know that this is attempt 2. Do so >> by saying [PATCH v2]. Your next one will be [PATCH v3]. The -v option >> for "git format-email" can help. > > Yao, I think Eric meant "git format-patch".
Correct. Sorry for the confusion. >> An alternate approach might be to use a multi-dimensional array, >> where the boolean values of rebasing, remote_is_branch, and origin >> are keys into the array. This would allow you to pick out the >> correct PRINT_LIST entry directly (no looping), thus eliminating >> the need for those b_rebasing, b_remote_is_branch, and b_origin >> members. > > Correct. > > After seeing so many "table driven" submissions, I however tend to > agree with your earlier comment on another thread on this same > micro, where you said an nested if-else cascade that was rewritten > in a clearer way (sorry, I do not remember whose submission it was It was Adam NoLastName [1]. [1]: http://thread.gmane.org/gmane.comp.version-control.git/243704 > offhand) may be the best answer to the "Would it make sense to make > the code table-driven?" question, even though I tentatively queued > d7ea7894 (install_branch_config(): simplify verbose messages logic, > 2014-03-13) from Paweł on 'pu'. Perhaps it is time to mark this microproject as "taken" on the GSoC page [2], along a fews others for which we have received multiple submissions. [2]: https://github.com/git/git.github.io/blob/master/SoC-2014-Microprojects.md -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
