Junio C Hamano wrote:
> Jonathan Nieder <jrnie...@gmail.com> writes:
>> We currently use "echo" all over the place (e.g., 'echo "$path"' in
>> git-sh-setup), and every time we fix it there is a chance of making
>> mistakes. I wonder if it would make sense to add a helper to make the
>> echo calls easier to replace:
> I agree that we would benefit from having a helper to print a single
> line, which we very often do, without having to worry about the
> boilerplate '%s\n' of printf or the portability gotcha of echo.
> I am a bit reluctant to name the helper "sane_echo" to declare "echo
> that interprets backslashes in the string is insane", though. For
> these "print a single line" uses, we are only interested in using a
> subset of the features offered by 'echo', but that does not mean the
> other features we do not want to trigger in our use is of no use to
> any sane person.
In a portable script, uncareful use of 'echo' is always insane.
In a script tailored to an environment where echo behaves consistently
it is perfectly reasonable to use 'echo', but that's a different
story. In the context of git, saying "Here is the thing you should
always use instead of echo" is a good thing, in my opinion.
Hoping that clarifies,
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html