Duy Nguyen <pclo...@gmail.com> writes:

> On Thu, Mar 20, 2014 at 6:46 PM, Matthieu Moy
> <matthieu....@grenoble-inp.fr> wrote:
>> Nguyễn Thái Ngọc Duy <pclo...@gmail.com> writes:
>>> git-compat-util.h does not seem to carry S_IXUGO. Anyway as far as Git
>>> is concerned, we only care one executable bit. Hard code it.
>> Why not use S_IXUSR instead of a hardcoded value? (already used in
>> path.c, so shouldn't be a problem wrt portability)
> Hmm..maybe cache.h does something to that macro. Will drop this patch
> and include cache.h.

Why even include cache.h for S_IXUSR?

In the context of the patch I see S_ISGID mentioned and other S_*
st_mode things are already in use in this function before this step,
and presumably you are using them without problems, no?
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to