On Thu, Mar 20, 2014 at 3:39 PM, George Papanikolaou
> Removing the bloat of checking for both '\r' and '\n' with the prettier
> iswspace() function which checks for other characters as well. (read: \f \t
Use imperative mood. "Remove" rather than "Removing".
Bloat? Prettier? Subjective stuff.
Did you verify that it is safe to strip all whitespace characters
rather than only line-endings? Perhaps say so in the commit message.
Why the choice of iswspace()? These are normal-width character
strings, so why apply a wide-character function?
> This is one more try to clean up this fuzzy_matchlines() function as part of a
> microproject for GSOC. The rest more clarrified microprojects were taken.
> I'm obviously planning on applying.
> Signed-of-by: George 'papanikge' Papanikolaou <g3orge....@gmail.com>
> builtin/apply.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/builtin/apply.c b/builtin/apply.c
> index b0d0986..912a53a 100644
> --- a/builtin/apply.c
> +++ b/builtin/apply.c
> @@ -295,9 +295,9 @@ static int fuzzy_matchlines(const char *s1, size_t n1,
> int result = 0;
> /* ignore line endings */
> - while ((*last1 == '\r') || (*last1 == '\n'))
> + while (iswspace(*last1))
> - while ((*last2 == '\r') || (*last2 == '\n'))
> + while (iswspace(*last2))
Doesn't this change turn the comment preceding this code into a
half-truth? Perhaps update the comment?
> /* skip leading whitespace */
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html