On Mon, Mar 24, 2014 at 11:22:58AM -0700, Junio C Hamano wrote:
> René Scharfe <l....@web.de> writes:
> > -test_expect_success 'log --grep -i' '
> > - git log -i --grep=InItial --format=%H >actual &&
> > - test_cmp expect_initial actual
> > -'
> > +test_log expect_initial --grep initial
> > +test_log expect_nomatch --grep InItial
> This, and the next --author one, assumes that we will never break
> "--grep=foo" without breaking "--grep foo". That should be OK, but
> we might want to add separate tests e.g.
> test_log expect_initial --grep=initial
> perhaps? I dunno.
Yeah, I I'd prefer "--grep=" here (and in all scripts). In general, I
think our attitude should be that "--foo=bar" is guaranteed to work
forever, but "--foo bar" is not. The latter only works if the argument
is non-optional, so that leaves us room to "break" compatibility to make
an argument optional in a future version.
Now, whether the rest of the world and its script-writers are aware of
this fact, I don't know. So it may be too late already (but it does look
like we mention it in gitcli(7)).
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html