The Git CodingGuidelines prefer the $( ... ) construct for command
substitution instead of using the back-quotes, or grave accents (`..`).
The backquoted form is the historical method for command substitution,
and is supported by POSIX. However,all but the simplest uses become
complicated quickly. In particular,embedded command substitutions
and/or the use of double quotes require careful escaping with the backslash
character. Because of this the POSIX shell adopted the $(…) feature from
the Korn shell.
Signed-off-by: Elia Pinto <gitter.spi...@gmail.com>
---
t/t9001-send-email.sh | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 1ecdacb..149a5b1 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -34,7 +34,7 @@ clean_fake_sendmail() {
}
test_expect_success $PREREQ 'Extract patches' '
- patches=`git format-patch -s --cc="One <o...@example.com>"
--cc=t...@example.com -n HEAD^1`
+ patches=$(git format-patch -s --cc="One <o...@example.com>"
--cc=t...@example.com -n HEAD^1)
'
# Test no confirm early to ensure remaining tests will not hang
@@ -1158,7 +1158,7 @@ test_expect_success $PREREQ '--no-bcc overrides
sendemail.bcc' '
'
test_expect_success $PREREQ 'patches To headers are used by default' '
- patch=`git format-patch -1 --to="bod...@example.com"` &&
+ patch=$(git format-patch -1 --to="bod...@example.com") &&
test_when_finished "rm $patch" &&
git send-email \
--dry-run \
@@ -1169,7 +1169,7 @@ test_expect_success $PREREQ 'patches To headers are used
by default' '
'
test_expect_success $PREREQ 'patches To headers are appended to' '
- patch=`git format-patch -1 --to="bod...@example.com"` &&
+ patch=$(git format-patch -1 --to="bod...@example.com") &&
test_when_finished "rm $patch" &&
git send-email \
--dry-run \
@@ -1182,8 +1182,8 @@ test_expect_success $PREREQ 'patches To headers are
appended to' '
'
test_expect_success $PREREQ 'To headers from files reset each patch' '
- patch1=`git format-patch -1 --to="bod...@example.com"` &&
- patch2=`git format-patch -1 --to="ot...@example.com" HEAD~` &&
+ patch1=$(git format-patch -1 --to="bod...@example.com") &&
+ patch2=$(git format-patch -1 --to="ot...@example.com" HEAD~) &&
test_when_finished "rm $patch1 && rm $patch2" &&
git send-email \
--dry-run \
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
