The test

    stdin -z create ref fails with zero new value

actually passes an empty new value, not a zero new value.  So rename
the test s/zero/empty/, and change the expected error from

    fatal: create $c given zero new value


    fatal: create $c missing <newvalue>

Of course, this makes the test fail now, because although "git
update-ref" tries to distinguish between these two errors, it does not
succeed in this situation.  Fixing it is more than a one-liner, so
mark the test test_expect_failure for now.  The failure will be fixed
later in this patch series.

Signed-off-by: Michael Haggerty <>
 t/ | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/ b/t/
index 6ffd82f..fa927d2 100755
--- a/t/
+++ b/t/
@@ -827,10 +827,10 @@ test_expect_success 'stdin -z create ref fails with bad 
new value' '
        test_must_fail git rev-parse --verify -q $c
-test_expect_success 'stdin -z create ref fails with zero new value' '
+test_expect_failure 'stdin -z create ref fails with empty new value' '
        printf $F "create $c" "" >stdin &&
        test_must_fail git update-ref -z --stdin <stdin 2>err &&
-       grep "fatal: create $c given zero new value" err &&
+       grep "fatal: create $c missing <newvalue>" err &&
        test_must_fail git rev-parse --verify -q $c

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to